Improve "Activities run as listed" tooltip wording#42813
Conversation
Agent-Logs-Url: https://github.com/fleetdm/fleet/sessions/9f6beee6-9e38-44a0-988b-9a69514e7452 Co-authored-by: getvictor <2685025+getvictor@users.noreply.github.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
@noahtalerman Please approve the wording here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #42813 +/- ##
==========================================
- Coverage 66.81% 66.81% -0.01%
==========================================
Files 2541 2540 -1
Lines 203971 203940 -31
Branches 9278 9266 -12
==========================================
- Hits 136282 136259 -23
+ Misses 55343 55336 -7
+ Partials 12346 12345 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the user-facing tooltip copy on the Host details “Upcoming activity” pane to clarify what “Activities run as listed” means.
Changes:
- Replaces the existing “guaranteed to run in order” wording with more direct language about sequential processing/waiting behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@getvictor tweaked the copy a bit. Just a reminder that all copy changes still go to design review. I'll bring this one to the next #g-security-compliance design review. |
Removed redundant information about activity failure.
The "Activities run as listed" tooltip on the host details upcoming activity pane said "Currently, only software and scripts are guaranteed to run in order" — ambiguous wording that implies the order is configurable or changeable.
frontend/pages/hosts/details/cards/Activity/Activity.tsx: Replace tooltip text with "Software and scripts are always processed in order. Each waits until the previous one completes." — accurately reflects the blocking/sequential behavior described in the contributing guide.